Build #3,372

Plan branch:
oneclient acceptance tests using environment deployed from packages

Build: #3372 was successful Child of ODSRV-OPRPM-2587

Stages & jobs

  1. Qnthack - copy quarantine

  2. Acceptance Test

  3. Qnthack - rerun

    Final

Test results

  • 1,878 tests in total
  • 2 tests were fixed
  • 55 tests were quarantined / skipped
  • 1505 minutes taken in total.
Fixed tests 2
Status Test Failing since View job Duration
Successful test_reg_file_CRUD test_network_restart_long[singleprovider_singleclient_proxyio]
Failing since build #3369 (Child of ODSRV-OPRPM-2584) regular file CRUD proxyio hardlinks 4 mins
Successful test_reg_file_CRUD test_network_restart_long[singleprovider_singleclient_proxyio]
Failing since build #3369 (Child of ODSRV-OPRPM-2584) regular file CRUD proxyio 4 mins
Quarantined tests 55
Status Test Failing since Quarantined by View job Duration
Successful test_multi_directory_CRUD test_rename_subfile_with_permission[multiprovider]
Łukasz Opioła Łukasz Opioła
multiprovider directory CRUD proxyio 41 secs
Successful test_multi_directory_stat test_change_access[multiprovider_s3]
Jakub Liput Jakub Liput
multiprovider s3 directory stat proxyio hardlinks 46 secs
Successful test_multi_reg_file_CRUD test_copy_big[multiprovider_directio]
Łukasz Opioła Łukasz Opioła
multiprovider regular file CRUD directio 41 secs
Successful test_multi_reg_file_CRUD test_create_many[multiprovider_directio]
Lukasz Dutka Lukasz Dutka
multiprovider regular file CRUD directio 53 secs
Successful test_multi_reg_file_CRUD test_create_many[multiprovider_proxyio]
Łukasz Opioła Łukasz Opioła
multiprovider regular file CRUD proxyio 51 secs
Successful test_multi_reg_file_CRUD test_create_many[multiprovider_s3]
Michał Stanisz Michał Stanisz
multiprovider s3 regular file CRUD proxyio hardlinks 58 secs
Successful test_multi_reg_file_CRUD test_create_many[multiprovider_s3]
Łukasz Opioła Łukasz Opioła
multiprovider s3 regular file CRUD proxyio 52 secs
Successful test_multi_reg_file_CRUD test_create_many[multiprovider_s3]
Łukasz Opioła Łukasz Opioła
multiprovider s3 regular file CRUD proxyio symlinks 1 min
Successful test_multi_reg_file_CRUD test_move[multiprovider_directio]
Łukasz Opioła Łukasz Opioła
multiprovider regular file CRUD directio 41 secs
Successful test_multi_reg_file_CRUD test_move[multiprovider_proxy]
Łukasz Opioła Łukasz Opioła
multiprovider proxy regular file CRUD proxyio hardlinks 26 secs
Successful test_multi_reg_file_CRUD test_move[multiprovider_proxy]
Łukasz Opioła Łukasz Opioła
multiprovider proxy regular file CRUD proxyio 54 secs
Successful test_multi_reg_file_CRUD test_move[multiprovider_proxy_s3]
Michał Wrzeszcz Michał Wrzeszcz
multiprovider proxy s3 regular file CRUD proxyio 24 secs
Successful test_multi_reg_file_CRUD test_move[multiprovider_proxy_s3]
Jakub Liput Jakub Liput
multiprovider proxy s3 regular file CRUD proxyio hardlinks 24 secs
Successful test_multi_reg_file_CRUD test_move[singleprovider_multiclient_directio]
Jakub Liput Jakub Liput
singleprovider regular file CRUD multiclient directio hardlinks 24 secs
Successful test_multi_reg_file_CRUD test_move[singleprovider_multiclient_directio]
Łukasz Opioła Łukasz Opioła
singleprovider regular file CRUD multiclient directio 28 secs
Successful test_multi_reg_file_CRUD test_move[singleprovider_multiclient_proxyio]
Jakub Liput Jakub Liput
singleprovider regular file CRUD multiclient proxyio hardlinks 26 secs
Successful test_multi_reg_file_CRUD test_move[singleprovider_multiclient_proxyio]
Michał Borzęcki Michał Borzęcki
singleprovider regular file CRUD multiclient proxyio 25 secs
Successful test_multi_reg_file_CRUD test_read_without_permission[multiprovider_proxy_s3]
Łukasz Opioła Łukasz Opioła
multiprovider proxy s3 regular file CRUD proxyio 24 secs
Successful test_multi_reg_file_CRUD test_recreate_and_read[multiprovider_directio]
Michał Wrzeszcz Michał Wrzeszcz
multiprovider regular file CRUD directio 55 secs
Successful test_multi_reg_file_CRUD test_recreate_and_read[multiprovider_proxyio]
Łukasz Opioła Łukasz Opioła
multiprovider regular file CRUD proxyio 1 min
Successful test_multi_reg_file_CRUD test_recreate_and_read[multiprovider_s3]
Łukasz Opioła Łukasz Opioła
multiprovider s3 regular file CRUD proxyio 57 secs
Successful test_multi_reg_file_CRUD test_write_with_permission[multiprovider_proxyio]
Michał Wrzeszcz Michał Wrzeszcz
multiprovider regular file CRUD proxyio 42 secs
Successful test_multi_reg_file_CRUD test_write_with_permission[multiprovider_proxyio]
Michał Stanisz Michał Stanisz
multiprovider regular file CRUD proxyio hardlinks 42 secs
Successful test_multi_reg_file_CRUD test_write_with_permission[multiprovider_s3]
Michał Stanisz Michał Stanisz
multiprovider s3 regular file CRUD proxyio hardlinks 42 secs
Successful test_multi_reg_file_CRUD test_write_with_permission[multiprovider_s3]
Lukasz Dutka Lukasz Dutka
multiprovider s3 regular file CRUD proxyio 42 secs
Collapse Failed test_multi_reg_file_stat test_change_access[multiprovider_proxy]
Michał Stanisz Michał Stanisz
multiprovider proxy regular file stat proxyio hardlinks 1 min 
AssertionError
fixturefunc = <function check_mode at 0x7f18bd1e0e00>
request = <FixtureRequest for <Function test_change_access[multiprovider_proxy]>>
kwargs = {'client_node': 'client21', 'file': 'space1/file1', 'mode': '211', 'user': 'user2', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(37 more lines...)
Collapse Failed test_multi_reg_file_stat test_change_access[multiprovider_proxy_s3]
Failing since build #3367 (Child of ODSRV-OPRPM-2583) Michał Stanisz Michał Stanisz
multiprovider proxy s3 regular file stat proxyio hardlinks 1 min 
AssertionError
fixturefunc = <function check_mode at 0x7f512b424e00>
request = <FixtureRequest for <Function test_change_access[multiprovider_proxy_s3]>>
kwargs = {'client_node': 'client21', 'file': 'space1/file1', 'mode': '211', 'user': 'user2', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(37 more lines...)
Collapse Failed test_multi_reg_file_stat test_change_access[singleprovider_multiclient_directio]
Michał Stanisz Michał Stanisz
singleprovider regular file stat multiclient directio hardlinks 1 min 
AssertionError
fixturefunc = <function check_mode at 0x7f391bf3ce00>
request = <FixtureRequest for <Function test_change_access[singleprovider_multiclient_directio]>>
kwargs = {'client_node': 'client21', 'file': 'space1/file1', 'mode': '211', 'user': 'user2', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(37 more lines...)
Collapse Failed test_multi_reg_file_stat test_change_access[singleprovider_multiclient_proxyio]
Michał Stanisz Michał Stanisz
singleprovider regular file stat multiclient proxyio hardlinks 1 min 
AssertionError
fixturefunc = <function check_mode at 0x7f2998f54e00>
request = <FixtureRequest for <Function test_change_access[singleprovider_multiclient_proxyio]>>
kwargs = {'client_node': 'client21', 'file': 'space1/file1', 'mode': '211', 'user': 'user2', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(37 more lines...)
Successful test_multi_reg_file_stat test_stat_change_time_mv[multiprovider_directio]
Jakub Liput Jakub Liput
multiprovider regular file stat directio hardlinks 1 min
Collapse Failed test_multi_reg_file_stat test_truncate_without_permission[multiprovider_proxy]
Michał Stanisz Michał Stanisz
multiprovider proxy regular file stat proxyio hardlinks 1 min 
AssertionError
fixturefunc = <function check_mode at 0x7f18bd1e0e00>
request = <FixtureRequest for <Function test_truncate_without_permission[multiprovider_proxy]>>
kwargs = {'client_node': 'client21', 'file': 'space1/dir1/file1', 'mode': '644', 'user': 'user2', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(37 more lines...)
Successful test_multi_reg_file_stat test_truncate_without_permission[multiprovider_proxy_s3]
Failing since build #3369 (Child of ODSRV-OPRPM-2584) Michał Stanisz Michał Stanisz
multiprovider proxy s3 regular file stat proxyio hardlinks 30 secs
Collapse Failed test_multi_reg_file_stat test_truncate_without_permission[singleprovider_multiclient_directio]
Michał Stanisz Michał Stanisz
singleprovider regular file stat multiclient directio hardlinks 1 min 
AssertionError
fixturefunc = <function check_mode at 0x7f391bf3ce00>
request = <FixtureRequest for <Function test_truncate_without_permission[singleprovider_multiclient_directio]>>
kwargs = {'client_node': 'client21', 'file': 'space1/dir1/file1', 'mode': '644', 'user': 'user2', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(37 more lines...)
Collapse Failed test_multi_reg_file_stat test_truncate_without_permission[singleprovider_multiclient_proxyio]
Michał Stanisz Michał Stanisz
singleprovider regular file stat multiclient proxyio hardlinks 1 min 
AssertionError
fixturefunc = <function check_mode at 0x7f2998f54e00>
request = <FixtureRequest for <Function test_truncate_without_permission[singleprovider_multiclient_proxyio]>>
kwargs = {'client_node': 'client21', 'file': 'space1/dir1/file1', 'mode': '644', 'user': 'user2', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(37 more lines...)
Collapse Failed test_multi_reg_file_stat test_type_empty[multiprovider_directio]
Michał Stanisz Michał Stanisz
multiprovider regular file stat directio symlinks 4 mins 
AssertionError
fixturefunc = <function shell_check_type at 0x7f13ce9f87c0>
request = <FixtureRequest for <Function test_type_empty[multiprovider_directio]>>
kwargs = {'client_node': 'client21', 'file': 'space1/file1', 'file_type': 'regular empty file', 'user': 'user2', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(33 more lines...)
Collapse Failed test_multi_reg_file_stat test_type_empty[multiprovider_proxy]
Michał Stanisz Michał Stanisz
multiprovider proxy regular file stat proxyio symlinks 3 mins 
AssertionError
fixturefunc = <function shell_check_type at 0x7f680ac5ca40>
request = <FixtureRequest for <Function test_type_empty[multiprovider_proxy]>>
kwargs = {'client_node': 'client21', 'file': 'space1/file1', 'file_type': 'regular empty file', 'user': 'user2', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(33 more lines...)
Collapse Failed test_multi_reg_file_stat test_type_empty[multiprovider_proxy_s3]
Michał Stanisz Michał Stanisz
multiprovider proxy s3 regular file stat proxyio symlinks 3 mins 
AssertionError
fixturefunc = <function shell_check_type at 0x7fbc5b4c4a40>
request = <FixtureRequest for <Function test_type_empty[multiprovider_proxy_s3]>>
kwargs = {'client_node': 'client21', 'file': 'space1/file1', 'file_type': 'regular empty file', 'user': 'user2', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(33 more lines...)
Collapse Failed test_multi_reg_file_stat test_type_empty[multiprovider_proxyio]
Michał Stanisz Michał Stanisz
multiprovider regular file stat proxyio symlinks 7 mins 
AssertionError
fixturefunc = <function shell_check_type at 0x7f53c07987c0>
request = <FixtureRequest for <Function test_type_empty[multiprovider_proxyio]>>
kwargs = {'client_node': 'client21', 'file': 'space1/file1', 'file_type': 'regular empty file', 'user': 'user2', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(33 more lines...)
Collapse Failed test_multi_reg_file_stat test_type_empty[multiprovider_s3]
Michał Stanisz Michał Stanisz
multiprovider s3 regular file stat proxyio symlinks 4 mins 
AssertionError
fixturefunc = <function shell_check_type at 0x7f792abd0a40>
request = <FixtureRequest for <Function test_type_empty[multiprovider_s3]>>
kwargs = {'client_node': 'client21', 'file': 'space1/file1', 'file_type': 'regular empty file', 'user': 'user2', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(33 more lines...)
Collapse Failed test_multi_reg_file_stat test_type_empty[singleprovider_multiclient_directio]
Michał Stanisz Michał Stanisz
singleprovider regular file stat multiclient directio symlinks 3 mins 
AssertionError
fixturefunc = <function shell_check_type at 0x7f2c8a2f0a40>
request = <FixtureRequest for <Function test_type_empty[singleprovider_multiclient_directio]>>
kwargs = {'client_node': 'client21', 'file': 'space1/file1', 'file_type': 'regular empty file', 'user': 'user2', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(33 more lines...)
Collapse Failed test_multi_reg_file_stat test_type_empty[singleprovider_multiclient_proxyio]
Michał Stanisz Michał Stanisz
singleprovider regular file stat multiclient proxyio symlinks 3 mins 
AssertionError
fixturefunc = <function shell_check_type at 0x7f3096ff4a40>
request = <FixtureRequest for <Function test_type_empty[singleprovider_multiclient_proxyio]>>
kwargs = {'client_node': 'client21', 'file': 'space1/file1', 'file_type': 'regular empty file', 'user': 'user2', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(33 more lines...)
Collapse Failed test_multi_reg_file_stat test_update_timestamp_with_permission[multiprovider_proxy]
Failing since build #3369 (Child of ODSRV-OPRPM-2584) Michał Stanisz Michał Stanisz
multiprovider proxy regular file stat proxyio hardlinks 1 min 
AssertionError
fixturefunc = <function check_mode at 0x7f18bd1e0e00>
request = <FixtureRequest for <Function test_update_timestamp_with_permission[multiprovider_proxy]>>
kwargs = {'client_node': 'client21', 'file': 'space1/dir1/file1', 'mode': '624', 'user': 'user2', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(37 more lines...)
Successful test_multi_reg_file_stat test_update_timestamp_with_permission[multiprovider_proxy_s3]
Failing since build #3367 (Child of ODSRV-OPRPM-2583) Michał Stanisz Michał Stanisz
multiprovider proxy s3 regular file stat proxyio hardlinks 27 secs
Successful test_multi_reg_file_stat test_update_timestamp_with_permission[singleprovider_multiclient_directio]
Michał Stanisz Michał Stanisz
singleprovider regular file stat multiclient directio hardlinks 26 secs
Successful test_multi_reg_file_stat test_update_timestamp_with_permission[singleprovider_multiclient_proxyio]
Michał Stanisz Michał Stanisz
singleprovider regular file stat multiclient proxyio hardlinks 30 secs
Collapse Failed test_multi_reg_file_stat test_update_timestamp_without_permission[multiprovider_proxy]
Failing since build #3368 (Child of ODSRV-OZP-2054) Michał Stanisz Michał Stanisz
multiprovider proxy regular file stat proxyio hardlinks 1 min 
AssertionError
fixturefunc = <function check_mode at 0x7f18bd1e0e00>
request = <FixtureRequest for <Function test_update_timestamp_without_permission[multiprovider_proxy]>>
kwargs = {'client_node': 'client21', 'file': 'space1/dir1/file1', 'mode': '644', 'user': 'user2', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(37 more lines...)
Collapse Failed test_multi_reg_file_stat test_update_timestamp_without_permission[multiprovider_proxy_s3]
Michał Stanisz Michał Stanisz
multiprovider proxy s3 regular file stat proxyio hardlinks 1 min 
AssertionError
fixturefunc = <function check_mode at 0x7f512b424e00>
request = <FixtureRequest for <Function test_update_timestamp_without_permission[multiprovider_proxy_s3]>>
kwargs = {'client_node': 'client21', 'file': 'space1/dir1/file1', 'mode': '644', 'user': 'user2', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(37 more lines...)
Collapse Failed test_multi_reg_file_stat test_update_timestamp_without_permission[singleprovider_multiclient_directio]
Failing since build #3367 (Child of ODSRV-OPRPM-2583) Michał Stanisz Michał Stanisz
singleprovider regular file stat multiclient directio hardlinks 1 min 
AssertionError
fixturefunc = <function check_mode at 0x7f391bf3ce00>
request = <FixtureRequest for <Function test_update_timestamp_without_permission[singleprovider_multiclient_directio]>>
kwargs = {'client_node': 'client21', 'file': 'space1/dir1/file1', 'mode': '644', 'user': 'user2', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(37 more lines...)
Collapse Failed test_multi_reg_file_stat test_update_timestamp_without_permission[singleprovider_multiclient_proxyio]
Michał Stanisz Michał Stanisz
singleprovider regular file stat multiclient proxyio hardlinks 1 min 
AssertionError
fixturefunc = <function check_mode at 0x7f2998f54e00>
request = <FixtureRequest for <Function test_update_timestamp_without_permission[singleprovider_multiclient_proxyio]>>
kwargs = {'client_node': 'client21', 'file': 'space1/dir1/file1', 'mode': '644', 'user': 'user2', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(37 more lines...)
Collapse Failed test_reg_file_CRUD test_replace[singleprovider_singleclient_directio]
Michał Stanisz Michał Stanisz
regular file CRUD directio symlinks 15 secs 
AssertionError
fixturefunc = <function replace at 0x7f3af939af20>
request = <FixtureRequest for <Function test_replace[singleprovider_singleclient_directio]>>
kwargs = {'file': 'space1/file1', 'text1': 'TEST', 'text2': 'SYSTEM', 'user': 'user1', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(37 more lines...)
Collapse Failed test_reg_file_CRUD test_replace[singleprovider_singleclient_proxyio]
Michał Stanisz Michał Stanisz
regular file CRUD proxyio symlinks 15 secs 
AssertionError
fixturefunc = <function replace at 0x7f25506b6f20>
request = <FixtureRequest for <Function test_replace[singleprovider_singleclient_proxyio]>>
kwargs = {'file': 'space1/file1', 'text1': 'TEST', 'text2': 'SYSTEM', 'user': 'user1', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(37 more lines...)
Collapse Failed test_reg_file_stat test_stat_change_time_mv[singleprovider_singleclient_directio]
Michał Stanisz Michał Stanisz
regular file stat directio symlinks 40 secs 
AssertionError
fixturefunc = <function check_time at 0x7fb936288180>
request = <FixtureRequest for <Function test_stat_change_time_mv[singleprovider_singleclient_directio]>>
kwargs = {'comparator': 'greater', 'file': 'space1/file2', 'time1': 'status-change', 'time2': 'modification', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(39 more lines...)
Collapse Failed test_reg_file_stat test_stat_change_time_mv[singleprovider_singleclient_proxyio]
Michał Stanisz Michał Stanisz
regular file stat proxyio symlinks 38 secs 
AssertionError
fixturefunc = <function check_time at 0x7f456a3f8180>
request = <FixtureRequest for <Function test_stat_change_time_mv[singleprovider_singleclient_proxyio]>>
kwargs = {'comparator': 'greater', 'file': 'space1/file2', 'time1': 'status-change', 'time2': 'modification', ...}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(39 more lines...)
Collapse Failed test_reg_file_stat test_type_empty[singleprovider_singleclient_directio]
Michał Stanisz Michał Stanisz
regular file stat directio symlinks 3 mins 
AssertionError
fixturefunc = <function shell_check_type at 0x7fb9362af2e0>
request = <FixtureRequest for <Function test_type_empty[singleprovider_singleclient_directio]>>
kwargs = {'file': 'space1/file1', 'file_type': 'regular empty file', 'user': 'user1', 'users': {'admin': <tests.utils.user_util...ests.utils.user_utils.User object at 0x7fb936376ae0>, 'user1': <tests.utils.user_utils.User object at 0x7fb936ddab10>}}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(37 more lines...)
Collapse Failed test_reg_file_stat test_type_empty[singleprovider_singleclient_proxyio]
Michał Stanisz Michał Stanisz
regular file stat proxyio symlinks 3 mins 
AssertionError
fixturefunc = <function shell_check_type at 0x7f456a40b2e0>
request = <FixtureRequest for <Function test_type_empty[singleprovider_singleclient_proxyio]>>
kwargs = {'file': 'space1/file1', 'file_type': 'regular empty file', 'user': 'user1', 'users': {'admin': <tests.utils.user_util...ests.utils.user_utils.User object at 0x7f456a4dc230>, 'user1': <tests.utils.user_utils.User object at 0x7f456a63c3e0>}}

    def call_fixture_func(
        fixturefunc: "_FixtureFunc[FixtureValue]", request: FixtureRequest, kwargs
    ) -> FixtureValue:
(37 more lines...)